Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Updated minio-go dependency to v6.0.56 to add two region endpoints #2705

Merged

Conversation

theunisbotha
Copy link
Contributor

@theunisbotha theunisbotha commented Jun 2, 2020

Signed-off-by: Theunis Botha [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Updated minio-go dependency to v6.0.56, which has support for the new af-south-1- (South Africa) and eu-south-1 (Milan) regions.

Verification

Tested by building a new docker image with the updated dependency and set it up to write to an AWS S3 Bucket in the af-south-1 region. After 2 hours, I checked the sidecar logs as well as our bucket to confirm that it was uploaded successfully.

@theunisbotha theunisbotha marked this pull request as ready for review June 2, 2020 15:42
@theunisbotha theunisbotha changed the title deps: Updated minio-go dependency to v6.0.56 to add af-south-1 region endpoint deps: Updated minio-go dependency to v6.0.56 to add two region endpoints Jun 2, 2020
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bwplotka bwplotka merged commit ab02e86 into thanos-io:master Jun 2, 2020
theunisbotha added a commit to theunisbotha/thanos that referenced this pull request Jun 4, 2020
…nts (thanos-io#2705)

* Updated minio dependency to v6.0.56 for af-south-1 region

Signed-off-by: Theunis Botha <[email protected]>

* Updated CHANGELOG.md

Signed-off-by: Theunis Botha <[email protected]>
theunisbotha added a commit to theunisbotha/thanos that referenced this pull request Jun 4, 2020
…nts (thanos-io#2705)

* Updated minio dependency to v6.0.56 for af-south-1 region

Signed-off-by: Theunis Botha <[email protected]>

* Updated CHANGELOG.md

Signed-off-by: Theunis Botha <[email protected]>
bwplotka pushed a commit that referenced this pull request Jun 4, 2020
…nts (#2705) (#2718)

* Updated minio dependency to v6.0.56 for af-south-1 region

Signed-off-by: Theunis Botha <[email protected]>

* Updated CHANGELOG.md

Signed-off-by: Theunis Botha <[email protected]>
paulfantom added a commit to paulfantom/thanos that referenced this pull request Jul 8, 2020
openshift/master

* upstream/release-0.13:
  Cut release v0.13.0
  shipper: Be strict about upload order unless it's specified so & cut v0.13.0-rc.2 (thanos-io#2765)
  Cut 0.13.0 release. (thanos-io#2762)
  Cut release 0.13.0-rc.1 (thanos-io#2720)
  Store: `irate` and `resets` use now counter downsampling aggregations. (thanos-io#2719)
  deps: Updated minio-go dependency to v6.0.56 to add two region endpoints (thanos-io#2705) (thanos-io#2718)
  store/proxy: Deduplicate chunks on StoreAPI level. Recommend chunk sorting for StoreAPI + Optimized iter chunk dedup. (thanos-io#2710) (thanos-io#2711)
  Allow using multiple memcached clients at the same time. (thanos-io#2648) (thanos-io#2698)
  Updated Prometheus as little as possible to include Isolation fix. (thanos-io#2697)
  Release fix attempt2.
  Fixed test job. (thanos-io#2650)
  Fixed promu build to build in compatible directory that crossbuild understands.
  Cut v0.13.0-rc.0 (thanos-io#2628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants